-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tracking PR: v0.6.0
#49
Draft
tcharding
wants to merge
6
commits into
rust-bitcoin:master
Choose a base branch
from
tcharding:01-23-release-0.6.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f22905c
to
ac517db
Compare
apoelstra
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ac517db; successfully ran local tests
In preparation for including `node` in the workspace run the formatter on `node`.
rustdoc expects to be on an item. Make the docs on `tmpdir` conform to rustdoc format.
ac517db
to
5cc7b7e
Compare
The `getbalances` RPC method is currently being feature guarded on `not(download)`. I'm not sure why but it seems unnecessary.
5cc7b7e
to
0490471
Compare
Currently we have a job for each supported version of Bitcoin Core and in it we run the integration tests. Note also that `node` is currently not a member of the workspace. So it misses out on all the benefits of `run_task` (e.g., linting). However `node` cannot be directly run using `run_task` because of its unusual features - it requires a version feature to build. Add a script to lint and one to run tests then call these from CI. While we are at it update the justfile now that `node` can be linted and formatted as part of workspace commands. Also update the `update-lock-files` script.
Add a brief readme file, point at `cargo run -- --help` and also at the docs we already wrote in `types/README.md`.
In preparation for release bump the version numbers of `types`, `client`, and `node` to `0.6.0`. Add changelog entries to each and update the lock files.
0490471
to
a55fe9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft till #53 goes in. Probably put #55 in first too.
This release is mainly because I want to introduce @jamillambert to this repository. Before doing so I want the everything in a state that he has some chance of understanding whats going on. We did a bunch of docs improvements, not much else.