Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking PR: v0.6.0 #49

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jan 23, 2025

Draft till #53 goes in. Probably put #55 in first too.

This release is mainly because I want to introduce @jamillambert to this repository. Before doing so I want the everything in a state that he has some chance of understanding whats going on. We did a bunch of docs improvements, not much else.

@tcharding tcharding marked this pull request as draft January 23, 2025 01:44
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch 2 times, most recently from f22905c to ac517db Compare February 4, 2025 22:42
@tcharding tcharding marked this pull request as ready for review February 4, 2025 22:42
@tcharding tcharding marked this pull request as draft February 5, 2025 04:55
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac517db; successfully ran local tests

In preparation for including `node` in the workspace run the formatter
on `node`.
rustdoc expects to be on an item. Make the docs on `tmpdir` conform to
rustdoc format.
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from ac517db to 5cc7b7e Compare February 6, 2025 21:53
The `getbalances` RPC method is currently being feature guarded on
`not(download)`. I'm not sure why but it seems unnecessary.
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from 5cc7b7e to 0490471 Compare February 6, 2025 22:32
Currently we have a job for each supported version of Bitcoin Core and
in it we run the integration tests.

Note also that `node` is currently not a member of the workspace. So it
misses out on all the benefits of `run_task` (e.g., linting).

However `node` cannot be directly run using `run_task` because of its
unusual features - it requires a version feature to build.

Add a script to lint and one to run tests then call these from CI.

While we are at it update the justfile now that `node` can be linted and
formatted as part of workspace commands. Also update the
`update-lock-files` script.
Add a brief readme file, point at `cargo run -- --help` and also at the
docs we already wrote in `types/README.md`.
In preparation for release bump the version numbers of `types`,
`client`, and `node` to `0.6.0`.

Add changelog entries to each and update the lock files.
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch from 0490471 to a55fe9b Compare February 6, 2025 22:45
@tcharding tcharding mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants